Skip to content

Unique Symbol Generation #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LSLeary
Copy link

@LSLeary LSLeary commented Jul 29, 2025

The project I want to test with io-sim uses Data.Unique, so I wrote this.

P.s. I'm not yet familiar with the library, let alone its internals—do let me know if I've written something silly.

Copy link
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions. A few minor comments.

@LSLeary
Copy link
Author

LSLeary commented Jul 31, 2025

Re the trace events, giving them the actual IOSimUnique s would require adding a type parameter to SimEventType or making the constructor existential in s. I'm not sure what the best choice is here, so for now it just holds the contained Integer.

Copy link
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can trace Integer rather than IOSimUnique, this will avoid the s parameter.

Copy link
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @LSLeary, the PR looks good to me. Just some minor things. Please squash the commits and I'll merge it.

@LSLeary LSLeary force-pushed the unique-symbol-generation branch from 90b4802 to 2479e6b Compare August 5, 2025 07:31
@coot coot enabled auto-merge August 6, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants